search

foobnix / LibreraReader

Book Reader for Android
http://librera.mobi
Other
3.09k stars 313 forks source link

Night reading mode will invert the color of all pictures in CBZ and CBR books #1099

Open GhostScript0r opened 1 year ago

GhostScript0r commented 1 year ago

When night mode is on, all the comic books in CBZ and CBR format will have the color inverted. Images in other formats like DOCX and EPUB are not affected. The issue is present on Librera 8.8.98 and 8.8.112 beta.

shkoda963 commented 1 year ago

Hello! This is a feature of the night mode.

GhostScript0r commented 1 year ago

Hello! This is a feature of the night mode.

I can see it useful when reading monochrome CBZ/CBR comics, but for comics with color it becomes unreadable in night mode.

kaine-nier commented 1 year ago

if you modify a color mode to have the text and background in pure black you’ll have the night mode you want. What i did is take the default day mode and just changed the white background color to black.

Omrigan commented 1 year ago

It could be useful to just be able to toggle color inversion for night mode. The usecase I have is reading PDFs, and looking at occasional images in their original colors.

I think people are battling the same issue in #886 and linked issues.

thomashastings commented 1 year ago

if you modify a color mode to have the text and background in pure black you’ll have the night mode you want. What i did is take the default day mode and just changed the white background color to black.

This would be an ideal case if only pictures are present. However, I use Librera to study from textbooks. Your suggestion truly fixes the issue with the images, but then the text disappears. Is there a way to set the font color though? I keep clicking the #000000 in the color configuration settings, and that hex must be the black color for the day mode, but only the background color selector keeps popping up.

chemicalcain commented 1 year ago

An individual settings toggle for color inversion in night mode would be nice. I've been using the day/night quick toggle but as mentioned that doesn't work very well for textbooks.

proski commented 1 month ago

It should be possible to convert the color to HSL and invert the lightness but keep the hue and the saturation. Ferris the crab is not supposed to turn blue at night.