FDroid release

[sdfg2]

Are you planning an fdroid release?

[IzzySoft]

That was the one I had in mind (but never get together myself) – thanks @Rudloff!

[foobnix]

@IzzySoft @Rudloff Thanks for the help, I see the app is available now :) Could you please also update info on the page https://f-droid.org/en/packages/com.foobnix.pro.pdf.reader/ 8.1.275-fdroid based on MuPDF 1.16.1 not 1.11

[IzzySoft]

@foobnix the website is updated asynchronously, so please give it a little.

Oh, wait: Summary and description are still part of our metadata here, so that would need another PR. May I suggest you setup Fastlane structures within your repo here, and we switch to that? Then you could take care for that all yourself, without any PR required on our end, and keep description etc. the way you need them. Just let us know then when it's done and tagged, so we update it one last time for switching over.

[foobnix]

@IzzySoft Please update from this fastline https://github.com/foobnix/LibreraReader/tree/master/fastlane You can also contribute and edit it by pull requests

Maybe better to use "en" but not "en-US" for all English speaking counties?

[IzzySoft]

@foobnix doesn't work that way. Please ping me again once a new tag is covering fastlane, has been built by F-Droid and showed up in the index. Then we can remove summary/description from our metadata (images should be pulled automatically).

As for "en" vs "en-US": I wondered about that as well. But that's out of my area (I care for apps' metadata, not for programming). Feel free to (check for and) open an issue at fdroidserver for that if you feel it important. To my understanding, it's rather cosmetical – at least as long "en-US" and "en" do not exist at the same time.

PS: I'm not an English native speaker, but shouldn't the summary read "Book reader for all formats", or "Book reader supporting all formats"? "of all formats" would IMHO mean the book reader itself consists of all formats.

[foobnix]

@IzzySoft @Rudloff Please find new release 8.1.303 and fastlane

[IzzySoft]

@Rudloff if that builds, will you switch to fastlane with your commit then? Or shall we rather postpone that switch until the version is listed with our index? In the latter case, feel free to ping me for that task once it can be performed.

[Rudloff]

Yes, I can probably switch to Fastlane at the same time.

Edit: I added 8.1.305-fdroid here.

[carsten-bruckhaus]

Hi, I hope I'm posting to the right issue. Version 8.1.275-fdroid introduced one or more bugs, where eBooks are displayed in a strange way when "Document" or "Document + User-defined" style is selected, e.g. when there are two figures one after another, they get "stacked" on top of each other, bullet points and frames around text are not displayed, etc. In the previous release, everything was fine, also in the Google Play Build everything is fine. Only the last two F-Droid releases are affected.

[foobnix]

@Thodor87 Fdroid version is build on the final Mupdf 1.16.1 has some pros and cons. We have fixed most of them in beta.librera.mobi alpha 8.1.320 version of Librera. Please create separate issue with screenshot and book if the problem still exists.

[foobnix]

Hello @IzzySoft @Rudloff Please find a new release 8.2.11

[Rudloff]

8.2.11-fdroid fails to build with this error:

Execution failed for task ':app:mergeFdroidReleaseJniLibFolders'.
> Could not list contents of '/home/vagrant/build/com.foobnix.pro.pdf.reader/app/src/main/jniLibs/arm64-v8a'. Couldn't follow symbolic link.

Do you know what could cause this?

[foobnix]

@Rudloff I have modified link_to_mupdf_1.16.1.sh, I think you need to update your replaces.

[Rudloff]

I added it here: https://gitlab.com/fdroid/fdroiddata/merge_requests/5974

[foobnix]

@Rudloff @IzzySoft My app is marked as This app has features you may not like. https://f-droid.org/wiki/page/Antifeature:KnownVuln

1) current APK has a weak MD5 signature You build and sign the apk yourself with your key. Why do you mark this security vulnerability?

2) uses a version of OpenSSL that has known vulnerabilities Librera F-Droid build is without Internet permission, I don't use and can't use the Internet at all. Even more, I don't' use OpenSSL in my app (maybe third-party libs use but I don't know)

Why do you mark my app as OpenSSL vulnerabilities?

Ivan

[Rudloff]

The KnownVuln wiki page is outdated and it only lists the most frequent reasons an app could have this anti-feature, it does not necessarily mean it applies to your app.

The anti-feature was added because of some vulnerabilities in MuPDF: https://gitlab.com/fdroid/fdroiddata/commit/5d504cb9e9c46c082e2d830ba361f0ca5dde8122 Since the app now uses MuPDF 1.16, I suppose this could be reconsidered. Feel free to open an issue here about this: https://gitlab.com/fdroid/fdroiddata/issues/new?issue%5Bassignee_id%5D=&issue%5Bmilestone_id%5D=

[foobnix]

@Rudloff Thanks https://gitlab.com/fdroid/fdroiddata/issues/1871

[foobnix]

@Rudloff Please find new release 8.2.29

[Rudloff]

I updated the metadata: https://gitlab.com/fdroid/fdroiddata/merge_requests/6211

[licaon-kter]

AutoUpdate looks ok now, some suffix issues were fixed in the meantime, but is there a chance to update versionName/Code just before you Tag the new version instead?

[foobnix]

@Rudloff @licaon-kter The new release is available, I hope your auto-update is working fine :)

[licaon-kter]

@foobnix Yup https://gitlab.com/fdroid/fdroiddata/-/merge_requests/6367

[licaon-kter]

@foobnix The version issue still stands. Eg. since you don't have static version* we can't use that to pick up new releases, we need to pick them up from elsewhere where the version is more or less one step ahead, and no corresponding tag to build, so the main build server just picks up unbuildable imaginary releases.

[foobnix]

@licaon-kter If I add something like, is it help you find static version number?

ext {
FDroidCodeNumber = 3704
FDroidVersionNumber = "8.3.33"
}

versionCode FDroidCodeNumber
versionName FDroidVersionNumber

[licaon-kter]

F-Droid reads 8.3.33 since your build.gradle says so. No tag for that yet.

The problem is that you modify the version ahead of time. The ideal situation would be that you modify version* when you Tag a release.

Adding yet another variable might help, but won't that be annoying to you? Maybe even forgotten from time to time? :)

[licaon-kter]

/close this issue as the app is actually published

[foobnix]

I will add FDroidCodeNumber and FDroidVersionNumber to the next tag 8.3.36

[foobnix]

@licaon-kter Could you please check tag 8.3.36 https://github.com/foobnix/LibreraReader/releases/tag/8.3.36

[licaon-kter]

https://gitlab.com/fdroid/fdroiddata/-/merge_requests/6590

[licaon-kter]

@foobnix Why do you keep updating the versionName/Code for F-Droid if you never Tag actual releases?

Ref: https://f-droid.org/wiki/page/com.foobnix.pro.pdf.reader/lastbuild_3780

[foobnix]

@licaon-kter I think you check tags only for a new release. I update the version for testers but the release is not ready.

[licaon-kter]

The checkupdate step is just a grep, if it finds something updated it thinks you've just updated and imediately later tagged.

If you update now and tag tomorrow, running the check now will add that new version...but of course it can't build.

[licaon-kter]

If we use Tags we need static versionName/Code.

If we use HTTP (as we do for this app) we grep a file for that versionName/Code...and we trust that a proper Tag exists.

[licaon-kter]

I'll open an issue so maybe we can combine them or smth.

Also seen here: https://github.com/MarcusWolschon/osmeditor4android/issues/1163

[licaon-kter]

FYI https://gitlab.com/fdroid/fdroidserver/-/issues/768

[Thewisem]

So anyone could explain why fdroid build is months old

[Thewisem]

Is none one updating it orrr

[Thewisem]

Is it the last update

[licaon-kter]

https://gitlab.com/fdroid/fdroiddata/-/commit/9f15532952726164c8731c90b7995c5780814ec3

Ref: https://f-droid.org/wiki/page/com.foobnix.pro.pdf.reader/lastbuild_4030

And: https://github.com/foobnix/LibreraReader/blob/8.3.109/app/build.gradle#L8

[Thewisem]

So since they can't rebuild it due to errors, that is the only version on fdroid

[Thewisem]

Dame

[yephny]

Any reason why this issue is still open? It seems to be resolved as the F-Droid version is up-to-date.

[ikanakova]

@yephny F-Droid version isn't up-to-date now again and maybe therefore there is no point in closing this issue when issue keeps repeating.

[yephny]

@ikanakova Oh, I thought it was just lagging behind, which isn't uncommon in F-Droid.

[soshial]

Looks like this issue is completed and should be closed? I cannot thank you enough @foobnix for your efforts to provide a clean version of your reader!

Do you mind if I kindly ask you to provide different donation opportunities (LiberaPay/OpenCollective/Github) in this repo's README and also maybe... your website.

Something like this:

[licaon-kter]

Yup, can close. And reopen in the future as needed :)

[rollingmoai]

Looks like this issue is completed and should be closed?

Yep seems like it, but it seems like the f-droid variant has some limitations. Can you include the PRO variant in your repo @IzzySoft? https://github.com/foobnix/LibreraReader/releases/download/8.8.76/Librera.Pro-8.8.76-uni.apk

[licaon-kter]

@rollingmoai "seems"? Which ones?

[rollingmoai]

https://f-droid.org/en/packages/com.foobnix.pro.pdf.reader

For better security, the F-Droid version, is based on the latest MuPDF 1.16.1 and does not require access to the Internet.

For the above reason, some Internet-related features of Librera Reader are missing in its F-Droid version: 1) Access to OPDS (Calibre) Catalogs 2) Google Drive Syncing 3) Access to Clouds (Dropbox, Google Drive, OneDrive) 4) Saving (sharing) pages from web browsers 5) Rendering MathML formulas in epub3 books 6) Access to the What's New page

[licaon-kter]

Ah, right, the stuff that's not free software or open-source.