foobnix / LibreraReader

Book Reader for Android
http://librera.mobi
Other
2.87k stars 305 forks source link

follow system theme #1117

Open jacekpoz opened 1 year ago

jacekpoz commented 1 year ago

I have my theme automatically switch between dark and light at specific times, would be great if I could make librera follow the system theme and automatically switch as well

BaruaAtish commented 1 year ago

I also agree. I think its really nice that the general Librera theme follows the system, and so getting the reading modes to follow said system theme as well without manually pressing the sun/moon icon would be really nice as well.

I think an option for this could be implemented in the preference page of the reading mode, next to the option of the bluelight filter. If one were to leave it unchecked, things would remain like the status quo, allowing one to change themes by pressing the moon/sun icon. But if one checks the option, the sun/moon icon dissapears and the reader follows the system theme (or whatever you customized your light and dark modes to look like).

chemicalcain commented 1 year ago

Counterpoint: I think this setting should exist, but the sun/moon icon should remain present in case certain books need manual override. Image-heavy files don't always look good in night mode since it inverts the colors.

BaruaAtish commented 9 months ago

Fair point. In that case though, since the purpose of the icon would be manual override, when its in the system theme option, let's have it revert back to system theme when the book is closed so that it both doesn't have to affect all other books, and at the same time doesn't force the app to make a history of each book's setting.