foobnix / LibreraReader

Book Reader for Android
http://librera.mobi
Other
2.81k stars 304 forks source link

Highlighting inital letters fixes #1160

Closed TheHardew closed 11 months ago

TheHardew commented 11 months ago

Thank you very much for providing this option in Librera! There are just some slight adjustments that could hopefully be made. So you can download the bionic reading app on the phone and play around with how it works, to see how it's implemented by the creators of the algorithm. Here are the main differences:

  1. In words with apostrophes (whether ' or the Unicode \’ ’ RIGHT SINGLE QUOTATION MARK) the part before the apostrophe should be treated as a single word
    e.g. don't -> don't so take only don as a 3 letter word and disregard 't
  2. In bionic reading you can choose the size of the highlighting. There are 5 options and reverse engineering them has been a little difficult, but I think it would be enough to provide the following:
    • words 1-3 letters long have only the first letter highlighted
    • words 4 letters long have 2 letters highlighted
    • longer words have round(A * length) letters highlighted, where A is a float provided by the user
foobnix commented 11 months ago

I see the bionic algorithm is a very different on web and in the application

Screenshot 2023-09-18 at 12 35 43
foobnix commented 11 months ago

please check new beta

TheHardew commented 11 months ago

that's the document I based my suggestions on:

It sadly does not say anything about the apostrophe, since it uses german as the example Playing around, maybe the right single quotation mark should be treated the same as an apostrophe then? That's what my books use and currently it is displayed this way: don’t -> don’t while it matches the web version it does not make much sense, since the function of that character is the same as that of an apostrophe

You can also see that they allow you to change the size of the fixation, and that would be helpful: image

TheHardew commented 11 months ago

So I believe the new beta disregards the part after the apostrophe. While now I'm not sure which version would be 'correct', that or using the whole word's length, I think it looks good, much better than treating them as 2 words, thank you very much

foobnix commented 11 months ago

please check beta 8.9.35 , you can send me the .txt and screenshots for check and for fix

Screenshot 2023-09-18 at 15 04 01
foobnix commented 11 months ago

beta 36

Screenshot 2023-09-18 at 15 15 52
TheHardew commented 11 months ago

Perfect, thank you!