search

foobnix / LibreraReader

Book Reader for Android
http://librera.mobi
Other
2.82k stars 304 forks source link

Hardcoded ndk path? #1161

Closed TheHardew closed 11 months ago

TheHardew commented 11 months ago

I believe in link_to_mupdf_1.23.3.sh the path to ndk is hard coded. And so is the version. Running this script did not build libMuPDF.so for me which resulted in a crashing binary. So it should try to find it and exit with a message and a non zero status when it can't.

TheHardew commented 11 months ago

My ndk is in /opt/android-ndk ANDROID_HOME and ANDROID_SDK_PATH are not set, but gradle got the path from sdk.dir in local.properties sdk.dir=/opt/android-sdk/ so ndk can be accessed at /opt/android-sdk/../android-ndk

foobnix commented 11 months ago

please modify as you want, I need at the same time two NDKs, one is the old NDK for mupdf 1.11 and the second NDK for the PRO version