foobnix / LibreraReader

Book Reader for Android
http://librera.mobi
Other
2.92k stars 309 forks source link

Option to see Epub3 page number (similar to moon+ readed) #1197

Closed Ovi329 closed 10 months ago

Ovi329 commented 10 months ago

Moon+ reader has added this option on their latest 8.6 update Screenshot_20231130-005607~2 It adds the ability to see the the page breaks/page numbers which is embedded in the epub3 file. (2nd picture) Screenshot_20231130-004807~2 Similar feature should be added to librera too

foobnix commented 10 months ago

Could you please send some epub3 book sample with pages

Ovi329 commented 10 months ago

epub3.zip

foobnix commented 10 months ago

Please find this in beta.librera.mobi you can also configure "page N" style by custom CSS for exmpaple pn {color:red}

Screenshot 2023-11-30 at 12 47 11 Screenshot 2023-11-30 at 12 40 00 Screenshot 2023-11-30 at 12 55 49
Ovi329 commented 10 months ago

Wow, that was pretty quick. Other open source projects take weeks to months to solve a single issue and you did it in like 15 hours. Thanks. Looks neat btw. Screenshot_20231130-170110

foobnix commented 10 months ago

it actually took 3 hours :) Do you think it is necessary to navigate through epub3 pages to quickly go for example "page 55"

Ovi329 commented 10 months ago

Yeah it'd be cool 👍

foobnix commented 10 months ago

Please find epub3 pages in outline

Screenshot 2023-11-30 at 14 53 40
Ovi329 commented 10 months ago

Page outlines work with a happy death but not the fall apparently Screenshot_20231130-201036

foobnix commented 10 months ago

"Page outlines work with a happy death but not the fall apparently" Can't clearly understand the issue.

Ovi329 commented 10 months ago

The page outlines work on the book "The fall" but doesn't work for "A happy death " The fall: Screenshot_20231130-201036~2 A happy death: Screenshot_20231201-023024~2

foobnix commented 10 months ago

Could you try to increase font size +1, i think this is old table context cache

Ovi329 commented 10 months ago

It worked 👍

TheHardew commented 10 months ago

There's already the "go to page" feature. Is there a need for a second one?

Screenshot_20231204_140612

It's the 3rd button from the left on the bottom.

foobnix commented 10 months ago

There's already the "go to page" feature. Is there a need for a second one?

Go to page navigate via rendered pages. Theoretically, I can add some char like "#"

10 - to go to publisher page location

foobnix commented 10 months ago

Please test in new beta

Screenshot 2023-12-04 at 16 09 22
TheHardew commented 10 months ago

I tried the test file in this thread and it does not open; "Unexpected error has occured" in both the beta and the stable version.

I also tried a few books from https://idpf.github.io/epub3-samples/30/samples.html like "Georgia" which is supposed to include page style navigation, but I did not see that, whether in the table of contents, the "go to page" menu or inside the book text. I do have the option turned on.

foobnix commented 10 months ago

Please install beta.librera.mobi F-Droid version, it will write crash.txt log in the Librera folder For me all books opening successfully, try to install "uni" version. What is andriod version on your device?

TheHardew commented 10 months ago

I'm stupid, I'm opening the zip as an epub...

TheHardew commented 10 months ago

So it seems the new button with the chain/link icon does not change anything, it still acts the same way as the previous method, going to the rendered Nth page. What is supposed to be the difference?

There is also the way to go to the Nth page from the table of contents.

Lastly, it seems that for the option to go to the Nth page to show up, one has to turn on the option to show the pages inside of the book, maybe they should be decoupled, it should always be possible to go to the Nth page if the book supports it and it should be rendered in book only if it's turned on

foobnix commented 10 months ago

Strange, for me it works... Type page "10" click "link" button its navigate to epub3 publisher 10 page

TheHardew commented 10 months ago

That does work. Clicking the link, then pressing on the 10th page does not. I thought it would act as a tab, so that it changes all the pages below.