foobnix / LibreraReader

Book Reader for Android
http://librera.mobi
Other
2.72k stars 297 forks source link

f-droid or github variant with networking, but not google services #1210

Closed eyecreate closed 7 months ago

eyecreate commented 7 months ago

As of right now(outside the google play store), you can either use Librera on f-droid, which removes all google services as well as networking or you can use the builds on github that have networking but also google services for google drive. Is there a way one of these variants(or a new one) can have networking in order to use features like OPDS, but without adding in google services?

foobnix commented 7 months ago

Librera PRO variant with networking, but not google services

eyecreate commented 6 months ago

The pro variant still contains Google drive.

foobnix commented 6 months ago

sorry, there is no variant with networking, but no google services

IzzySoft commented 6 months ago

But would you consider creating such a variant? In exchange, I'd include that one with my repo then, see https://gitlab.com/IzzyOnDroid/repo/-/issues/472 for reference. Currently, with 5 "offending libs" it's just beyond the threshold of permitted "inclusion criteria violaters".

Offending libs:
---------------
* JUnrar (/com/github/junrar): NonFreeComp
* Google Mobile Services (/com/google/android/gms): NonFreeComp
* Google API Client Libraries (/com/google/api/client): NonFreeNet
* Google Drive API (/com/google/api/services/drive): NonFreeDep,NonFreeNet
* Google Java API Client Services (/com/google/api/services): NonFreeNet

5 offenders.

It here was a variant without GDrive (which I guess is what drags in the other 3 Google libs), that would just leave JUnrar – which I do not believe is that essential (so it could ideally also be removed from that variant), but being the single left offender it would be "tolerable".

I've no idea why F-Droid removed all networking stuff altogether and consider OPDS a thing a reader should offer (well, not last out of self-interest, as I run an OPDS enabled eBook server myself), which is why I'd be totally willing making an exception to include an app already present at F-Droid, as that would be a very good reason.

Deal, @foobnix?

foobnix commented 6 months ago

Please check the new F-Droid 8.9.129 build with Internet enabled beta.librera.mobi. While I believe that a F-Droid build with disabled internet access enhances security, enabling it is not a problem if you prefer :)

eyecreate commented 6 months ago

Is the intent that future f-droid builds will now include network?

foobnix commented 6 months ago

@eyecreate yes all future f-droid builds will be with internet

IzzySoft commented 6 months ago

@eyecreate so that solves you issue then, and inclusion with my repo would not be needed – as the new F-Droid build will have what the two of us were after?

@foobnix thanks then! Well done :smiley:

eyecreate commented 6 months ago

Yep, this seems to solve was I was looking for!

nvllz commented 6 months ago

Why would you want the application, which can potentially execute malicious network code from some PDF files (it largely depends on 3rd party mupdf), to have the Internet permission? What are the advantages? It's a kind of downgrade. You could get the google play version if you need internet with this app. I remember when there was an FDroid warning saying that this app contains malicious code, which seemed to be the fault of some 3rd party libraries. I can see no reason behind opening network sockets for this app guys.

serrq commented 6 months ago

I would like no internet, no Google version. Does it exist?