search

foobnix / LibreraReader

Book Reader for Android
http://librera.mobi
Other
3.08k stars 313 forks source link

F-Droid build failed #960

Open linsui opened 2 years ago

linsui commented 2 years ago

Those api key are hiddened now. Though they are not used for F-Droid build the build failed without them.

> Could not get unknown property 'librera_appGdriveKey' for ProductFlavor$AgpDecorated_Decorated{name=beta, dimension=version, minSdkVersion=null, targetSdkVersion=null, renderscriptTargetApi=null, renderscriptSupportModeEnabled=null, renderscriptSupportModeBlasEnabled=null, renderscriptNdkModeEnabled=null, versionCode=null, versionName=null, applicationId=com.foobnix.pdf.reader, testApplicationId=null, testInstrumentationRunner=null, testInstrumentationRunnerArguments={}, testHandleProfiling=null, testFunctionalTest=null, signingConfig=null, resConfig=[], buildConfigFields={}, resValues={}, proguardFiles=[], consumerProguardFiles=[], manifestPlaceholders={}, wearAppUnbundled=null} of type com.android.build.gradle.internal.dsl.ProductFlavor$AgpDecorated.

Could you please take a look? Thanks!

soshial commented 1 year ago

Is this issue resolved, @linsui?

linsui commented 1 year ago

I patched the code. But it's better to fix it upstream.

Lampotrias commented 1 year ago

I had same error when I made gradle sync. How can I fix this error?

Build file '/home/mihail/work/LibreraReader/app/build.gradle' line: 121

A problem occurred evaluating project ':app'.
> Could not get unknown property 'librera_appGdriveKey' for ProductFlavor$AgpDecorated_Decorated{name=beta, dimension=version, minSdkVersion=null, targetSdkVersion=null, renderscriptTargetApi=null, renderscriptSupportModeEnabled=null, renderscriptSupportModeBlasEnabled=null, renderscriptNdkModeEnabled=null, versionCode=null, versionName=null, applicationId=com.foobnix.pdf.reader, testApplicationId=null, testInstrumentationRunner=null, testInstrumentationRunnerArguments={}, testHandleProfiling=null, testFunctionalTest=null, signingConfig=null, resConfig=[], buildConfigFields={}, resValues={}, proguardFiles=[], consumerProguardFiles=[], manifestPlaceholders={}, wearAppUnbundled=null} of type com.android.build.gradle.internal.dsl.ProductFlavor$AgpDecorated.
gaoyu03 commented 3 weeks ago

I meet the same mistake when gradle sync, anyone know how to fix this issue??

linsui commented 3 weeks ago

https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/com.foobnix.pro.pdf.reader.yml#L1272 Just remove those lines. :shrug: