Ad-hoc translation of article names having shared article

foodcoop-adam / foodsoft

DEPRECATED, being merged in upstream. Web-based software for foodcoops - as used in NL.

http://foodcoop-adam.github.io/

Other

10 stars 3 forks source link

Ad-hoc translation of article names having shared article #147

Closed wvengen closed 9 years ago

wvengen commented 9 years ago

Vokomokum needs to have English article names in addition to the local language. We can do this by having a foodcoop-local article name, either in a new database column, or have a setting where (per article) the article name can be not synchronised.

Work-in-progress at foodcoops/feature/sync_skip_columns

[x] Add sync_skip_columns to Article
[x] Skip synchronisation on specified columns
[x] Show checkbox in user-interface
[ ] Use bootstrapicons/gyphicons with toggle button instead of checkbox
[x] Connect checkbox to sync_skip_columns
[ ] Make sync screen enter old values for skipped fields in changed articles
[ ] Test if functionality works (with updating sharedlists article)
[ ] Update value from shared article when unchecking column using ajax / data attribute
[ ] Remove disabled from input when unchecking column

wvengen commented 9 years ago

Being able to specify which fields are synchronised per article would be great. This would be stored in a new column containing the list of column names to synchronize. We'll implement this first in the user-interface for the name only.

wvengen commented 9 years ago

Temporary fixed by adding a foodcoop-note for shared articles. It would be nice to finish this, as it would bring a lot of clarity as to what the fields mean for shared articles.

wvengen commented 9 years ago

Since this is not really required anymore, I'd like to close this until the need comes up again.

Cor-Jan commented 9 years ago

I have no idea what it means. Can you explain?

On Tuesday, November 18, 2014, wvengen notifications@github.com wrote:

Since this is not really required anymore, I'd like to close this until the need comes up again.

— Reply to this email directly or view it on GitHub https://github.com/foodcoop-adam/foodsoft/issues/147#issuecomment-63558010 .

wvengen commented 9 years ago

The approach we wanted to use for allowing translated articles names was to include the translated name in the note field. For shared articles, this meant that the article name needed to be not overwritten when synchronized.

To tackle this more generally, we started work to allow a foodcoop to choose which fields would be synchronized. But it proved a larger task than we had the time for.

In the meantime, I added a foodcoop-note in addition to the supplier's note for shared articles. This is now used to set the English name of a product, and shown in the article info popup in the member ordering screen (group_orders).

Since we have a solution for the title of this issue, I'd like to close this ticket. We can refer back to this issue when we'd like to allow foodcoops to select which article fields need to be synchronised, and which not.