foodcoops / foodsoft

Web-based software to manage a non-profit food coop (product catalog, ordering, accounting, job scheduling).
https://foodcoops.net/
Other
318 stars 146 forks source link

Preselect more fields when creating new user #1066

Closed twothreenine closed 2 weeks ago

twothreenine commented 2 months ago

In my experience, admins easily forget to set all options correctly when creating a new user. This lead to many users having their language set to English although a translation exists (but often they don't know that they can change it or how) or unintentionally having their phone and email private (i.e. only visible to admins), which really hampers communication within the coop.

I chose to create only one config option for all three privacy options in order not to create too many config options.

One questionable consequence of this is that, if the config option is enabled, created users will have the setting "name is visible" set to true (visible in the admin/users/show view) even if nicknames are disabled, so "name is visible" is irrelevant. This also means, if you later enable nicknames, the names of the respective users will remain visible (unless changed in their profiles), which I think is good.

yksflip commented 3 weeks ago

thanks @twothreenine! If you think this are the better defaults for foodcoops, then why just not default it for all instead of adding another config option? Do you think this is something other foodcoops might dislike? If possible I'd like to avoid adding more config options...

Besides that, it looks good to me! :)

twothreenine commented 3 weeks ago

Food coops have different policies for opting-in / opting-out privacy options. For example, in "IG Foodsoft" (a super-Foodsoft for the Austrian food coops) we wouldn't enable this setting as we don't want to expose phone numbers and emails to thousands of users. There might also be other rather anonymous coops where contact details should only be visible to admins. But for many smaller coops, it would be useful.