foodcoopsat / foodsoft_hackathon

Other
1 stars 2 forks source link

Some numbers not localized (decimal point/comma) #60

Closed twothreenine closed 6 months ago

twothreenine commented 6 months ago

In German, these numbers should be with decimal comma instead of decimal point: grafik

The unit content (in brackets) also affects the order placement menu. grafik

lentschi commented 6 months ago

In German, these numbers should be with decimal comma instead of decimal point

That seems to be a firefox bug: https://stackblitz.com/edit/stackblitz-starters-wq7ukz?file=index.html

<input type="number" value="1.0">
<input type="number" value="1.3">

<- In Chrome (v123.0.6312.105 with the preferred content language set to German) both those inputs look like this: grafik

In firefox (124.0.2) the first input (the one with a value of "1.0") uses a dot as a decimal separator for some inexplicable reason: grafik

I couldn't find that precise bug on bugzilla, but to me it seems to be a bug. (Or at least I don't get why those two inputs should behave differently.)

One could work-around this by fixing the associated rails issue: Not passing zero insignificant zeroes to decimal inputs, but that would be quite some effort as we'd have to either wrap the simple form input logic, or manually custom format the value in each occurrence in the templates, so I'm closing this for now.

The unit content (in brackets) also affects the order placement menu.

That part is fixed. :+1: