Show order [management]: Adapt column headings? + append supplier order unit for all articles?

twothreenine commented 6 months ago

Column headings: "Members" is confusing and was never translated. I suggest changing it to "Total order", or whatever term we agree on in #63. Same for "Full units" -> "Order result"?

Then for some articles, the supplier order unit isn't shown in the far right column:

In case of beer, you wouldn't know if it refers to 20.0 l or 20.0 x Bottle (0.5 l).
In case of potatoes, we need it since it differs from the group order unit.
For carrots & oyster mushrooms (supplier order unit == group order unit) we don't really need it, I'm unsure if it should be appended for the sake of completeness or omitted to underline it's the same as the group order unit.

grafik

This also applies to the receive menu: grafik

twothreenine commented 5 months ago

I thought about the terminology in the column headings across various views, also in regards to upstream/#1016. My key thoughts:

there should be a consistent terminology in the frontend
some headings should depend on the order's state

Here are my notes, which go beyond this issue and also beyond the aim of this fork: Hackathon received etc columns.xlsx

lentschi commented 3 months ago

The issue with the missing units is fixed by https://github.com/foodcoopsat/foodsoft_hackathon/commit/b38dfb0c25be9ef3f1a6eee7d17615043c0ce9bf, the issue with the column renaming/ordering remains, but is not directly related to the fork, so I'll move it to the post-merge milestone.

foodcoopsat / foodsoft_hackathon

Show order [management]: Adapt column headings? + append supplier order unit for all articles? #64