search

foodcoopsat / foodsoft_hackathon

Other
1 stars 2 forks source link

Support decimal comma in article CSV numbers (upload) #81

Closed twothreenine closed 2 months ago

twothreenine commented 2 months ago

When I try to upload a CSV (user language set to German) with a minimum order quantity of 1,2 [kg], I get an error.

In upstream, prices with decimal comma are supported in CSV upload, so other columns should support this as well, I think. (I haven't tested the other new columns.)

For the ratios column: Might decimal commas lead to problems here?

I can't find where to change this. I tracked the process until https://github.com/foodcoopsat/foodsoft_hackathon/blob/5be0082171f026d289cb43368cc42756637660d0/app/controllers/articles_controller.rb#L264 but I don't know where supplier_articles_path(@supplier) leads. @lentschi

lentschi commented 2 months ago

For the ratios column: Might decimal commas lead to problems here?

Yes, as now our separator between ratios is a colon (as I think we agreed upon in https://github.com/foodcoopsat/foodsoft_hackathon/issues/47 - too lazy to read through all of that though :sweat_smile:), we logically cannot use it as a decimal point too.