search

foodinme / burgatron

The great thinking engine of foodin.me
MIT License
0 stars 0 forks source link

Filter out businesses that aren't open #1

Open mboeh opened 10 years ago

mboeh commented 10 years ago

Yelp has the info about whether businesses are open, but they don't expose it via their API.

Foursquare has hours. We'd have to parse them. I also don't know if the hours are reliable or always there.

Google Places has hours, too: https://developers.google.com/places/documentation/details

Google Places also lets you filter results by whether they're open. We might want to add a third source for it.

How do we want to handle cases where we can't determine if a business is open? Leave it out?

mboeh commented 10 years ago

Annoyingly, Foursquare doesn't return hours in their 'compact' venue results, so you incur an API call to get the hours for each venue.

Also, a ton of places don't have hours. We'd lose a lot of good choices if we excluded them. Los Gorditos doesn't, for instance. Nor does the Powell hotcake house.

mboeh commented 10 years ago

Foursquare lets you filter out sources that aren't open if you use their 'explore' endpoint instead of search. @rjfranco As much as I love the idea of combining sources, I think we should consider just using Foursquare. I wanted to use 4SQ to validate the hours of Yelp results, but that's not really going to be feasible with the APIs as implemented.

Also, Foursquare's terms of service are kind of grumpy about combining their data with other services' data anyway. They want you to explicitly call out which data came from which source, which is a fuckin' PITA if you ask me. Just using their API would make things a bit simpler. What do you think?

rjfranco commented 10 years ago

I'm ok with that, I think it's a higher priority to be able to call out which places are open than combining data.