rewrite blocks rendering in php - Githubissues

foodlydoodlydoo / 2019.1-fdd-block

0 stars 0 forks source link

rewrite blocks rendering in php #3

Closed foodlydoodlydoo closed 5 years ago

foodlydoodlydoo commented 5 years ago

https://github.com/WordPress/gutenberg/issues/4849#issuecomment-477677215

foodlydoodlydoo commented 5 years ago

notes for next time:

bare inner blocks still must be saved in js save(), or it's lost
attributes must be defined to conform this code: https://developer.wordpress.org/reference/functions/rest_validate_value_from_schema/, with type and default, but NOT source and selector (those look for it in the saved content, which is null).

fixed for existing blocks with https://github.com/foodlydoodlydoo/2019.1-fdd-block/commit/f02850486ee2afe4568b3e40a2411aa02d5eefeb, https://github.com/foodlydoodlydoo/2019.1-fdd-block/commit/990aa9dbd13fb517647e7f78e061290fb682db50