search

foogod / go-powerwall

A Go library for communicating with Tesla Powerwall appliances via the local-network API
MIT License
6 stars 7 forks source link

GetMetersAggregates should return map, not pointer to map #1

Open andig opened 2 years ago

andig commented 2 years ago

I'm looking to using this library as part of https://evcc.io. Thank you very much for providing it!

Map is already a dynamic data structure and nullable. Adding another layer of indirection just makes it confusing.

andig commented 2 years ago

ping @foogod any chance to look into the two open PRs?

andig commented 2 years ago

ping @foogod any chance?