foojayio / discoapi

The foojay discovery api (discoapi) is made to discover java packages (jre/jdk) from different distributions.
GNU General Public License v2.0
111 stars 13 forks source link

Cannot request package info for GraalVM CE with distribution name "Graal VM CE XX" #51

Closed repolevedavaj closed 1 year ago

repolevedavaj commented 2 years ago

If I try to request the package info for a specific GraalVM distribution with "Graal VM CE XX" as distribution name, I get a 400 status. If I use "GraalVM CE XX" as name, it works. According to https://api.foojay.io/disco/v2.0/distributions?include_versions=false, "Graal VM CE XX" is the official name and "GraalVM CE XX" just a synonym.

HanSolo commented 2 years ago

The api_parameter in the response from https://api.foojay.io/disco/v2.0/distributions?include_versions=false is the value that should be used for the query

repolevedavaj commented 2 years ago

Ah I see. Thanks for the quick feedback!

sschuberth commented 1 year ago

Hmm, so while graalvm_ce11 is listed as an api_parameter, https://api.foojay.io/disco/v3.0/packages?distro=graalvm_ce11 says "No package(s) found". Is this expected @HanSolo? Because for some other distro like https://api.foojay.io/disco/v3.0/packages?distro=oracle_open_jdk it seems to work.

HanSolo commented 1 year ago

Hmm...that's not correct, thx for the heads up, will take a look at it 👍🏻

jbartok commented 1 year ago

For my own clarification: is the right/recommended way of setting the distro param for packages using the api_parameter or the name of distributions?

sschuberth commented 1 year ago

The api_parameter should be used, see above.

HanSolo commented 1 year ago

Already found the issue, it is related to the introduction of graalvm early access builds, will fix it asap and will close this issue as soon as it will be working as expected and be available in production.

sschuberth commented 1 year ago

will close this issue as soon as it will be working as expected and be available in production.

Thanks! However, then you should probably reopen this issue first :grin:

HanSolo commented 1 year ago

Released the latest version to production and now it should work again as expected...could you please give it a try?

sschuberth commented 1 year ago

Looking good to me now, thanks a lot for the fast fix @HanSolo!

HanSolo commented 1 year ago

Great, thx again for the report and testing 👍🏻😁