Reduce dependency list - Githubissues

foojayio / discoclient

A Java library that makes it easier to access the foojay disco api

Apache License 2.0

6 stars 7 forks source link

Open emilianbold opened 3 years ago

emilianbold commented 3 years ago

It would be nice to restrict the dependency list to a minimum:

I see 4 logging dependencies while none is required (except as a transitive dependency from HttpClient5)
the javax.validation dependency is not really required as those annotations, while useful, are used in a single class. (And, I would say, there are better libraries that provide such annotations).

HanSolo commented 3 years ago

I agree, I also saw the useless logging dependencies...

aalmiray commented 2 years ago

The minimum set of dependencies may be

    implementation("com.google.code.gson:gson:2.8.8")
    implementation("org.slf4j:slf4j-api:1.7.25")

Also, set them in the api scope.

The log4j dependencies might be needed for testing, if so move them to testImplementation scope.

aalmiray commented 2 years ago

And don't forget to bump the slf4j-api version to the latest release 😉