search

foojayio / nbplugin2

A NetBeans plugin to download and install any OpenJDK build using the OpenJDK Discovery Service from foojay.io
Apache License 2.0
2 stars 0 forks source link

DiscoClient cannot be included in NetBeans #42

Closed emilianbold closed 3 years ago

emilianbold commented 3 years ago

As far as I can tell, NetBeans still expects to build on Java 8. This means that discoclient, which uses that Java 11 HttpClient cannot be included.

If the foojay backend has some documentation we could re-implement discoclient using some Java 8 APIs/libraries like the Apache Commons HttpClient 3.1 which NetBeans already includes.

emilianbold commented 3 years ago

Also related to issue #40

emilianbold commented 3 years ago

@geertjanw while there is value in having discoclient as a separate JAR for other clients, I think we should just include the code from discoclient in the plugin. It makes no sense to have another "3rd party jar" wrapped in the module.

It might make a bit of sense if discoclient were to be published on Maven Central which, right now, it is not.

I'm also mildly wondering if it's worth having these 2 codebases under different licenses. In particular, using discoclient introduces the need for a NOTICE file entry.

geertjanw commented 3 years ago

Sure. Makes sense.

emilianbold commented 3 years ago

I think this can be closed. discoclient has a java8 branch and is included as a JAR and will be on Maven Central in the future. There isn't much actionable in this issue anymore.