search

fookatchu / pyphotonfile

Library for reading and writing files for the Anycubic Photon 3D-Printer (.photon and .cbddlp)
GNU General Public License v3.0
24 stars 9 forks source link

It may make sense to upstream your specs into https://github.com/kaitai-io/kaitai_struct_formats/ #23

Open KOLANICH opened 3 years ago

ingobecker commented 3 years ago

Hey, i started a complete rewrite of the parser using construct. The specs, as present in this repository do not correctly parse newer versions of the fileformat. If i remeber correctly, construct allows to export kaitai files. Once the parser does parse files correctly, i will try to let construct generate kaitai files and see if it makes sense to upstream them. Otherwise i might complete the existing files for upstreaming.

KOLANICH commented 3 years ago

If i remeber correctly, construct allows to export kaitai files.

Yeah, and KSC can generate Construct files.

ingobecker commented 3 years ago

I initially tried to generate contruct code from the kaitai files. Parsing worked as expected, but generating binary files did not. Thats why i had to write code manually. I will try to clean up the changes i made so i can release a new version. Maybe i will just release the extended kaitai files i have, but it would be nice to have kaitai files, that were generated by the construct code, so its guaranteed they match with working code.