Styling is not good in Edge - Githubissues

fooloomanzoo / datetime-picker

A minimal picker for date and time for Polymer, that can use the native input

MIT License

78 stars 18 forks source link

Styling is not good in Edge #46

Closed fat-crienturu closed 6 years ago

fat-crienturu commented 6 years ago

In Edge the datetime-picker doesn't look very good.

the width of the inputs is too small so it cuts off the last number.
colors of the date and time separators is white so it's not visible.
when a date or time is selected, then everything turns white so nothing is visible any more.

When you define your own colors, then there are also issues in the calendar/time popup:

font color for the month, year and time inputs turns white even if they were defined as black This is Edge (month, year and time are not visible in the popup):

This is Chrome (everything is visible):

Here is a codepen which demonstrates the issues: https://codepen.io/anon/pen/MVBjxr

fooloomanzoo commented 6 years ago

It should be fixed with the new version 2.8.7. Please consider the new way of styling.

fat-crienturu commented 6 years ago

Unfortunately it didn't fix any of the issues. Here is the codepen with the new version: https://codepen.io/anon/pen/PRLJyx

The same thing can be seen in this demo when you select the date: https://www.webcomponents.org/element/fooloomanzoo/datetime-picker/demo/demo/index.html

Could you please reopen the issue?

fooloomanzoo commented 6 years ago

Are you shure that you really updated every dependency with bower update -f? For the webcomponents page it could also be necessary to clear the browser cache. Everything works for me in IE 11.

fat-crienturu commented 6 years ago

Thank you for looking into it. I didn't update any dependencies. In the codepen I'm using the ones you're serving: https://raw-dot-custom-elements.appspot.com/fooloomanzoo/datetime-picker/2.8.7/datetime-picker

I tried clearing the cache for Edge, but it didn't help. It also work in IE11 for me.

I'm assuming you don't have Windows 10 to try it out in Edge. Do you know that Microsoft has free virtual machines with Edge for testing: https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ Could you maybe try it in that?

fooloomanzoo commented 6 years ago

Thanks for the link. I will try it out

fooloomanzoo commented 6 years ago

@fat-crienturu In the newest version it should be fixed. In edge inputs are sized differently and it has problems with currentColor.

fooloomanzoo commented 6 years ago

@fat-crienturu you could try it in this codepen

fat-crienturu commented 6 years ago

@fooloomanzoo thank you for the fixes, that looks much better.

I noticed there is still one issue left, the time part in the popup is still white so it's not visible on a white background.

fooloomanzoo commented 6 years ago

@fat-crienturu Yes, I just saw that too. Is fixed in 2.8.9

fat-crienturu commented 6 years ago

@fooloomanzoo Just tried 2.8.9. Works great, thank you very much.