search

fooloomanzoo / datetime-picker

A minimal picker for date and time for Polymer, that can use the native input
MIT License
78 stars 18 forks source link

Typing values manually #63

Closed madiganz closed 5 years ago

madiganz commented 5 years ago

Currently the element allows a user to keep typing numbers into the date or time fields. This causes the date to get completely messed up. For example, let's say a date is 10/30/2018. If a user adds a 1 to the day, it will add 301 days and display what that date + 301 days is. I would expect the element to not accept input after maximum values are reached.

fooloomanzoo commented 5 years ago

Reason for this kind of behavior was, to enable to shift to next or prevois month for example. In the new behavior when you type a too large value for day for example, the new date will be at the next month's first day.

madiganz commented 5 years ago

So you are saying that it goes to the next month's first day? If this was applied to my example, it would take you to 11/01/2018, correct? I do not see this happening.

fooloomanzoo commented 5 years ago

On which site are you testing? On your local test-setup or on github/webcomponents? Those demos-sites I will update soon, but if you install it, it should work or I can not reproduce your issue

madiganz commented 5 years ago

I was able to reproduce it on both. What version was this updated in? I am currently running v2.9.1 locally, which is most likely the reason.

fooloomanzoo commented 5 years ago

The newest version was published in the last days. In 2.9.4 your "issue" should be solved

madiganz commented 5 years ago

Awesome, thanks for the information.