search

fooman / emailattachments-implementation-m2

Implementation package for https://github.com/fooman/emailattachments-m2
14 stars 7 forks source link

finish void return type cleanup #12

Closed pedrosousa13 closed 5 years ago

pedrosousa13 commented 5 years ago

@fooman I found that it was still breaking so I cleaned up the void return types. Maybe later we can add the return void in the PHPDOC instead? What do you think? :)

pedrosousa13 commented 5 years ago

@fooman I was actually reading more about this issue and we could just add a return;. If we do that, : void will be valid also. Relevant info: https://stackoverflow.com/questions/35482195/php7-void-return-type-not-working

fooman commented 5 years ago

@pedrosousa13 I am okay with just the removal here (this is after all how it was on prior versions). The 2.2.8 upgrade unfortunately back-ported the emailing behaviour from 2.3.0 which caught me off guard.

Will revisit the return type question once support for lower php versions can be dropped.

fooman commented 5 years ago

Thanks again for picking these up - which version of php are you currently running?

pedrosousa13 commented 5 years ago

In this current project I'm using php 7.1

fooman commented 5 years ago

Do you mind sharing an error message with a stack trace as I am not 100% sure yet that I am seeing the same that you are.

pedrosousa13 commented 5 years ago

@fooman do you have an email that I can contact you with?