Optimise Compatibility With Mandrill

fooman / emailattachments

Magento 1 Extension - add order confirmation, invoice, packing slip or creditmemo pdfs to your outgoing transactional emails. Also adds support for attaching terms and conditions and printing the order as a pdf.

http://store.fooman.co.nz/extensions/magento-extension-email-attachments.html

22 stars 22 forks source link

Optimise Compatibility With Mandrill #14

Closed sprankhub closed 9 years ago

sprankhub commented 9 years ago

The setType method is not available on objects of type Mandrill_Message.
The addAttachment method is not available on objects of type Mandrill_Message, but the createAttachment method is. I do not see any disadvantage by using createAttachment.

fooman commented 9 years ago

Hi Simon, thanks for the pull request in reply to

The addAttachment method is not available on objects of type Mandrill_Message, but the createAttachment method is. I do not see any disadvantage by using createAttachment.

We did initially use createAttachment - the reason we switched to addAttachment is that it allows us to set the encoding to UTF-8 which createAttachment can't do. If I remember correctly it became an issue on the file name in some email clients. Are you able to rewrite this so that createAttachment is used on the Mandrill object and stays as is if not?

sprankhub commented 9 years ago

Here you go...

fooman commented 9 years ago

Great - thanks!