fooman / emailattachments

Magento 1 Extension - add order confirmation, invoice, packing slip or creditmemo pdfs to your outgoing transactional emails. Also adds support for attaching terms and conditions and printing the order as a pdf.
http://store.fooman.co.nz/extensions/magento-extension-email-attachments.html
22 stars 22 forks source link

add compatibility to Aschroder_Email (aka MageSend) in queue rewrites #18

Closed arosenhagen closed 8 years ago

fooman commented 8 years ago

Thanks for that. Would you mind confirming what version number Aschroder_Email released a similar change to this https://github.com/aschroder/Magento-SMTP-Pro-Email-Extension/commit/02870086fad48021d80a7a22e4c265b7bd9fd54b

arosenhagen commented 8 years ago

as of Aschroder_Email v1.1.1 (current) the mentioned code looks like:

Mage::dispatchEvent('aschroder_email_queue_before_send', array(
  'mail' => $mailer,
  'transport' => $transport
));

Don't know exactly what this has to do with the rewrite conflict resolved in this PR, so I just paste the code so you might have a hint about it :-)

fooman commented 8 years ago

Hmm if it doesn't have 'message' => $message in the event dispatch then it is actually not compatible as currently the queue class from Aschroder_Email would be used. We would also need to add an event listener for aschroder_email_queue_before_send once the message is part of the event dispatch.

fooman commented 8 years ago

I have this currently reversed in the latest release until such time that I have confirmation of inclusion of the event in Aschroder_Email.