fooman / emailattachments

Magento 1 Extension - add order confirmation, invoice, packing slip or creditmemo pdfs to your outgoing transactional emails. Also adds support for attaching terms and conditions and printing the order as a pdf.
http://store.fooman.co.nz/extensions/magento-extension-email-attachments.html
22 stars 22 forks source link

Check compatibility with SUPEE-7405 security patch #19

Closed hostep closed 8 years ago

hostep commented 8 years ago

Hi guys

Just noticed in the recently published SUPEE-7405 security patch, the method Mage_Core_Model_Email_Queue::send is patched.

Since this project overwrites this method in Fooman_EmailAttachments_Model_Core_Email_Queue_Fooman::send it might be a good idea to also patch it?

Here is the diff from SUPEE-7405 (for Magento CE 1.9.1.0, haven't checked the other versions yet):


                 try {
                     $mailer->send();
+                } catch (Exception $e) {
+                    Mage::logException($e);
+                }
+
                 unset($mailer);
                 $message->setProcessedAt(Varien_Date::formatDate(true));
                 $message->save();
             }
-                catch (Exception $e) {
-                    unset($mailer);
-                    $oldDevMode = Mage::getIsDeveloperMode();
-                    Mage::setIsDeveloperMode(true);
-                    Mage::logException($e);
-                    Mage::setIsDeveloperMode($oldDevMode);
-
-                    return false;
-                }
-            }
         }

         return $this;

What do you think?

Thanks!

fooman commented 8 years ago

Makes sense.