fooman / googleanalyticsplus

Magento Extension to add extra features to the default GoogleAnalytics module.
http://store.fooman.co.nz/extensions/magento-extension-googleanalyticsplus.html
100 stars 53 forks source link

Error: missing quotes #8

Closed dborneman closed 10 years ago

dborneman commented 10 years ago

Google tag managers 'sometimes' gives an error that quotes are missing around the string values of the object.

fooman commented 10 years ago

Please define sometimes. Can you please view the html source of your page and let me know what works and what doesn't. Currently this report is too unspecific for us to do anything about.

studio2f commented 10 years ago

I see this too. Here's a 'siteview' page. There's two items in the cart. I don't think the cart products are supposed to be included on a 'siteview' page. Cart items are not included on a 'home' page but they are showing as well on the 'searchresults' pages.

Chrome Google Tag Assistant

studio2f commented 10 years ago

I'm no longer getting the Minor Issue warning about missing quotes in 0.13.12

fooman commented 10 years ago

0.13.13 will now only show ecomm_prodids and ecomm_totalvalue on cart, product and purchase pages.

I'll close this one for now - please reopen if the issue persists.

studio2f commented 10 years ago

Installed 0.13.13. Is the ecomm_totalvalue supposed to be a cart total? right now it's listing each product's price seperately.

Chrome Google Tag Assistant

fooman commented 10 years ago

Google's documentation on this is perfectly confusing.

ecomm_totalvalue 49.99 Total Value - Specify the value of the product. On a cart or purchase page, you need to specify the total value (summing up the value of all products). This value might be used in automated bidding optimization and may be used to categorize your lists into groups according to the value of products.

but then providing this on the same page under common mistakes

Multiple values in a parameter without brackets. For example:

<script type="text/javascript">
var google_tag_params = {
ecomm_prodid: "123,"234",
ecomm_pagetype: "cart",
ecomm_totalvalue: 100,50
};
</script>

Should be changed to:

<script type="text/javascript">
var google_tag_params = {
ecomm_prodid: ["123","234"],
ecomm_pagetype: "cart",
ecomm_totalvalue: [100,50]
};
</script>

The same shows as working on my end: google-remarketing-cart-multiple-products