search

fooman / googleanalyticsplus

Magento Extension to add extra features to the default GoogleAnalytics module.
http://store.fooman.co.nz/extensions/magento-extension-googleanalyticsplus.html
100 stars 53 forks source link

Row Total on Cart Page excl. tax should be incl. tax #94

Closed mikebranderhorst closed 6 years ago

mikebranderhorst commented 8 years ago

The Product Price on Product Page is incl. tax, the Row Total on Cart Page should also be incl. tax.

https://github.com/fooman/googleanalyticsplus/blob/master/app/code/community/Fooman/GoogleAnalyticsPlus/Block/Remarketing.php#L119

https://github.com/fooman/googleanalyticsplus/blob/master/app/code/community/Fooman/GoogleAnalyticsPlus/Block/Remarketing.php#L129

'%01.2f', Mage::helper('googleanalyticsplus')->convert($basketItem, 'row_total')

should be:

'%01.2f', Mage::helper('googleanalyticsplus')->convert($basketItem, 'row_total_incl_tax')

fooman commented 8 years ago

Can you confirm if this is always the case or only if the setting System > Configuration > Tax > Price Display Settings > Display Product Prices In Catalog is set to Including Tax?

mikebranderhorst commented 8 years ago

In the current code base the setting is always excluding tax. My solution is always including tax. It should be coded to include if given setting is including tax.

fooman commented 6 years ago

Will be fixed in 0.18.2