search

fooman / googleanalyticsplus

Magento Extension to add extra features to the default GoogleAnalytics module.
http://store.fooman.co.nz/extensions/magento-extension-googleanalyticsplus.html
100 stars 53 forks source link

Value should have two decimals #95

Closed mikebranderhorst closed 6 years ago

mikebranderhorst commented 8 years ago

https://github.com/fooman/googleanalyticsplus/blob/master/app/code/community/Fooman/GoogleAnalyticsPlus/Helper/Data.php#L52

return $baseValue;

should be:

sprintf('%01.2f', $baseValue);

https://github.com/fooman/googleanalyticsplus/blob/master/app/code/community/Fooman/GoogleAnalyticsPlus/Helper/Data.php#L56

"%01.4f", Mage::app()->getStore()->roundPrice(

should be:

'%01.2f', Mage::app()->getStore()->roundPrice(

Like the remarketing value:

https://github.com/fooman/googleanalyticsplus/blob/master/app/code/community/Fooman/GoogleAnalyticsPlus/Block/Remarketing.php#L119

https://github.com/fooman/googleanalyticsplus/blob/master/app/code/community/Fooman/GoogleAnalyticsPlus/Block/Remarketing.php#L129

fooman commented 6 years ago

Will be changed in 0.18.2