search

foomo / simplecert

golang autocert library for letsencrypt
MIT License
212 stars 34 forks source link

simplecert.Init erroring wrongly #23

Closed azukaar closed 1 year ago

azukaar commented 1 year ago

The simplecert.Init is throwing an error when it cannot renew certificate, but it should just return a nil, and invoke the FailedToRenewCertificate callback so that certificate renewal issues can be sovled the same way whether the server is already started or not

(@dreadl0ck sorry for the ping, but you mentioned we should ping you!)

dreadl0ck commented 1 year ago

Hey thanks for raising this, I will look into it asap.

dreadl0ck commented 1 year ago

Fixed in: https://github.com/foomo/simplecert/releases/tag/v1.8.5

Thanks for reporting!

azukaar commented 1 year ago

Thanks you!