search

foonathan / memory

STL compatible C++ memory allocator library using a new RawAllocator concept that is similar to an Allocator but easier to use and write.
https://memory.foonathan.net
zlib License
1.5k stars 194 forks source link

Fix build with BUILD_SHARED_LIBS=ON #132

Closed MiguelCompany closed 2 years ago

MiguelCompany commented 2 years ago

This should fix #131 by deprecating virtual_memory_page_size and adding function get_virtual_memory_page_size().

foonathan commented 2 years ago

Hm, this is a breaking change. Maybe it's better to call the function get_virtual_memory_page_size() and have a (deprecated) static const std::size_t virtual_memory_page_size = get_virtual_memory_page_size()? That being said, it probably doesn't matter. I leave the decision up to you.

MiguelCompany commented 2 years ago

I do prefer non-breaking changes, so I just added the getter function that returns the constant.

foonathan commented 2 years ago

Thank you!