search

foonathan / memory

STL compatible C++ memory allocator library using a new RawAllocator concept that is similar to an Allocator but easier to use and write.
https://memory.foonathan.net
zlib License
1.5k stars 195 forks source link

Update CMakeLists.txt fix include path #165

Closed jiayuehua closed 1 year ago

jiayuehua commented 1 year ago

https://github.com/microsoft/vcpkg/pull/31905

jiayuehua commented 1 year ago

@foonathan

foonathan commented 1 year ago

Can you elaborate on the consequences and reason for this change?

jiayuehua commented 1 year ago

If installed to include/foonathan, then client code must use include "foonathan/foonathan/memory…" other than include "foonathan/memory".

after this fix, some other vcpkg port that already rely on your memory lib can work again.

also from https://github.com/microsoft/vcpkg/pull/30212 

CMake Error in src/cpp/CMakeLists.txt:
  Imported target "foonathan_memory" includes non-existent path

    "D:/installed/x86-windows/include/foonathan_memory"

  in its INTERFACE_INCLUDE_DIRECTORIES.
foonathan commented 1 year ago

Okay, that's fair. Thanks.