Hey @bostlund - everything here looks really good! I left one comment on the code for an unfinished note in one of the files that might be worth fixing.
Otherwise, my main thoughts where some small potential (broadly unimportant) tweaks to the code. To avoid asking you to do pedantic things, and not jump directly onto the PR and potentially create a Github merging pickle, I've collected some brief comments in this issue here: https://github.com/fooof-tools/DevelopmentalDemo/issues/5. What I recommend is that we merge this PR in now (whenever you are ready). After that, if you agree with the small proposed edits, I'll go through and do them separately.
Hey @bostlund - everything here looks really good! I left one comment on the code for an unfinished note in one of the files that might be worth fixing.
Otherwise, my main thoughts where some small potential (broadly unimportant) tweaks to the code. To avoid asking you to do pedantic things, and not jump directly onto the PR and potentially create a Github merging pickle, I've collected some brief comments in this issue here: https://github.com/fooof-tools/DevelopmentalDemo/issues/5. What I recommend is that we merge this PR in now (whenever you are ready). After that, if you agree with the small proposed edits, I'll go through and do them separately.