fooof-tools / fooof

Parameterizing neural power spectra into periodic & aperiodic components.
https://fooof-tools.github.io/
Apache License 2.0
363 stars 98 forks source link

[MNT] - Plot & report tweaks #287

Closed TomDonoghue closed 1 year ago

TomDonoghue commented 1 year ago

This is a set of minor updates to plotting and styling.

One goal is to reduce the number of warnings that are popping up - in particular around applying tight_layout, and the warnings that became more common saying "this figure can't have that". In doing so, it tweaks how plot style functions get applied (allowing for passing in None's to turn them off). It also updates how styling gets applied to group report plots, as the previous approach had issues with the twinned axes (would only get one of them, leading to different label sizes).

In part, this relates to at some point, something external seeming to have changed in terms of interpreting the figure sizes, such that our figures now seem to be printed bigger (?). This seems to be version specific - the current PR tweaks sizes to look better for me on py3.8 (in notebooks), whereas running on py36, they now look a little small...

In terms of review - code updates are fairly minor, but it would be nice for people to check that running this branch leads to to figures that look good (hopefully a bit better than before), and that there are no / fewer warnings.

Also - this is my final anticipated update for 1.1! After this, I have nothing else, and can think about tagging final 1.1