search

fooof-tools / fooof

Parameterizing neural power spectra into periodic & aperiodic components.
https://fooof-tools.github.io/
Apache License 2.0
345 stars 93 forks source link

Frequency Range not working #327

Open TurboAlpaca opened 1 week ago

TurboAlpaca commented 1 week ago

When defining the frequency range to plot it uses the default values. I am unable to change it for either plotting, reporting, or fitting the model to the PSD. I've copied and pasted the code from the tutorial and it still does not work. I checked using the latest version available on google colab and in V.S. code python 3.11 with version specparam - 2.0.0

image

TomDonoghue commented 4 days ago

Hey @TurboAlpaca - thanks for the note on this, this is a bug / issue in the current development release that accidentally failed to pass the frequency range parameter through internally.

It's already been in fixed in the follow commit (which is part of this branch / PR): https://github.com/fooof-tools/fooof/commit/42abfed2dddb635dba097e6aab359ba08cb0557e

This means that the current development version on that branch is fixed, but any install from PYPI will currently have this bug. There should be a new release to PYPI soon (but might be a few days / a week or two) as I'm currently travelling. In the meantime, you can step back to the rc1 version, which shouldn't have this issue, and/or install from the above linked PR for the fix.

TurboAlpaca commented 2 days ago

Great, this was able to solve the issue! Thank you for the quick response.