search

foostan / crkbd

Corne keyboard, a split keyboard with 3x6 column staggered keys and 3 thumb keys.
Creative Commons Attribution 4.0 International
5.43k stars 964 forks source link

./plates/common/*.svg files broken #107

Closed ceceba223 closed 3 years ago

ceceba223 commented 3 years ago

The .svg files for the plate are incomplete, meaning that the blue and red cut-lines aren't visible. Here is a screenshot of the bottom.svg opend in Inkscape. This is also an error with other .svg files in the repositorie.

keyboard-magpie commented 3 years ago

https://imgur.com/a/JcsbuDI

If viewed in a CAD program they are fully visible (this is QCAD on mac, freecad etc produce a similar view).

ceceba223 commented 3 years ago

I tried opening the file in LibreCAD but got the same problem.

keyboard-magpie commented 3 years ago

I should prob do a PR with some working DXFs...

ceceba223 commented 3 years ago

What DXFs there are only .svg and .ai files

keyboard-magpie commented 3 years ago

I have some I've made locally.

keyboard-magpie commented 3 years ago

https://github.com/keyboard-magpie/crkbd-plate-files

CarrasTec commented 3 years ago

The .svg files for the plate are incomplete, meaning that the blue and red cut-lines aren't visible. Here is a screenshot of the bottom.svg opend in Inkscape. This is also an error with other .svg files in the repositorie.

The issue is the width of the lines, what I did was select all and then go to the properties of the lines and increase the witdh.

foostan commented 3 years ago

It seems good to change the width of line.

foostan commented 3 years ago

Thank you your commitment! https://github.com/foostan/crkbd/pull/112 I'll close this issue.