football / Prediction-League

phpBB Football Prediction League Extension 3.1.x and 3.2
http://football.bplaced.net
GNU General Public License v2.0
0 stars 1 forks source link

Getting controller helper instance #1

Closed rxu closed 7 years ago

rxu commented 8 years ago

In all ACP modules there's he code for getting controller helper like this:

        $provider           = new \phpbb\controller\ provider();
        $symphony_request   = new \phpbb\ symfony_request($request);
        $filesystem         = new \phpbb\ filesystem();
        $helper             = new \phpbb\controller\ helper($template, $user, $config, $provider, $phpbb_extension_manager, $symphony_request, $request, $filesystem, $phpbb_root_path, $phpEx);

This can be simplified, which also will make it upcoming phpBB 3.2 compatible, by replacing with the 1 line:

$helper = $phpbb_container->get('controller.helper');
football commented 7 years ago

Fixed in new Version. Thnk You.