search

fooyin / fooyin

A customisable music player
https://www.fooyin.org
GNU General Public License v3.0
497 stars 15 forks source link

Crash when adding files/directories? #135

Closed Unnepad closed 1 month ago

Unnepad commented 3 months ago

I noticed a problem the first time I tried this player.

For some reason, the player just crashes when loading a file or directory within the application. This also happens if the player was started from the terminal.

This is fixed if the tray icon is enabled (although if you load a directory and then disable the tray icon, it also crashes). I don't know why, but I guess that prevents the program from exiting.

ludouzi commented 3 months ago

What OS/DE are you using? Did you install fooyin via a package?

Unnepad commented 3 months ago

I'm using Fedora 40 (Plasma spin), and I installed it via the .rpm package from this repository.

ludouzi commented 3 months ago

Thanks, I'm going to try and reproduce this.

Something that may help in the meantime is to try installing from the COPR repo here. If that works fine, it's likely a problem with the packaging.

Unnepad commented 3 months ago

I also tried the COPR repo, but still has the same issue.

ludouzi commented 3 months ago

I can't reproduce this on a fresh install of Fedora 40 (Plasma). Does it give any useful terminal output when it crashes?

Unnepad commented 3 months ago

For some reason, no, it doesn't leave any error message. Plasma doesn't detects it too.

It seems that it's fault of the file picker (though that doesn't explains why it quits when disabling the tray). It exists even if I click cancel.

I will leave a record if that helps. Maybe there's a debug option or something? bug.webm

ludouzi commented 3 months ago

Thanks for the video. It looks like fooyin isn't actually crashing but quitting when the file dialog finishes; that helps narrow it down.

What version of Qt do you have installed?

Unnepad commented 3 months ago

I don't know how to find that. What commands should I use?

ludouzi commented 3 months ago

For KDE it should be System Settings->System->About this System

Unnepad commented 3 months ago

Oh, right. It says version 6.7.1

ludouzi commented 3 months ago

Alright, I've managed to reproduce it using the same Qt version. Working on a fix.

ludouzi commented 3 months ago

Looks like this is related to this regression: https://bugreports.qt.io/browse/QTBUG-124386.

As this is fixed in Qt 6.7.2, you'll have to wait for when that is released (or for Fedora to include a patch).

You can try using other platform themes to get around this for now like:

QT_QPA_PLATFORMTHEME=generic fooyin
Unnepad commented 3 months ago

Ouch :disappointed: So it is actually a bug from the Qt engine itself. There's also the workaround I mentioned previously, so it shouldn't be a problem for now.

Btw, this is actually a nice Qt player, specially for being modular and straightforward. The others (Audacious, Qmmp) are somewhat less polished and optimized.

ludouzi commented 1 month ago

As Qt 6.7.2 is available for Fedora 40, I'll consider this resolved.