search

fooyin / fooyin

A customisable music player
https://www.fooyin.org
GNU General Public License v3.0
441 stars 14 forks source link

Album artwork not being picked up for CUE files #140

Open LukeZBaker opened 2 months ago

LukeZBaker commented 2 months ago

Thanks for adding CUE support.

For my CUE files (FLAC), there's no album artwork being displayed for covers stored in files. This issue happens in the directory browser as well as the other modes (e.g. Vision, Obsidian).

ludouzi commented 2 months ago

I can't seem to reproduce this. Are you talking about embedded artwork in a single multi-track FLAC file? Does this occur for all CUE files, or only some?

LukeZBaker commented 2 months ago

It's occurring for all my CUE/FLAC files, none of which have embedded artwork but have album covers in the same directory which should be found by %path%/Cover.* but aren't.

ludouzi commented 2 months ago

I'm still unable to reproduce this. Could you share an image of one of the directories, or preferably, one of the files for testing?

ludouzi commented 2 months ago

To add to this, files associated with a CUE sheet are not treated any differently after they've been scanned/added to a library. If the FLAC files play correctly, then their path is correct and the path used for %path% will be correct also.

Without testing one of the files affected, another potential cause is the parsing of the directory paths in the Artwork settings page, as that currently depends on new line characters to split the entries. You could try clearing it and only adding %path%/cover.*.

LukeZBaker commented 2 months ago

Apologies, was away.

I cleared the directory paths in the Artwork settings page. Seems ok now.