search

for-GET / http-decision-diagram

An activity diagram to describe the resolution of HTTP response status codes, given various headers.
https://github.com/for-GET/http-decision-diagram/blob/master/doc/2013-06-10-http-hell-no.md
Apache License 2.0
3.61k stars 196 forks source link

Omits 428 Precondition Required #50

Closed DavidBiesack closed 2 years ago

DavidBiesack commented 6 years ago

Nice diagram. The flow does not specify checks for required preconditions (If-Match required) and the 428 response if omitted.

andreineculau commented 6 years ago

Thanks, David!

That's correct - 428 is currently not in the diagram. Did you give it any thought as to where to place the check(s)?

I can see another precondition mistake: the missing=true case where the client gives if-none-match:* i.e. "create only if it doesn't exist already". Currently that ends up in missing_has_precondition:true -> respond with 412.

One thing at a time though. First let's figure out 428.

andreineculau commented 6 years ago

RFC reference https://tools.ietf.org/html/rfc6585#section-3

KillerBoogie commented 2 years ago

The diagram is fantastic! Thanks. Will this issue be fixed? It is more than 4 years old?

andreineculau commented 2 years ago

@KillerBoogie fixed by who? 🤔 Send a PR or at least make a suggestion.

Having this issue opened for 4 years, and only 2 participants means that it's not a high prio.