Move away from OTP 18 and adopt rebar3_lint 0.3.0

for-GET / jesse

jesse (JSon Schema Erlang) is an implementation of a JSON Schema validator for Erlang.

https://github.com/for-get/jesse

Apache License 2.0

126 stars 64 forks source link

Move away from OTP 18 and adopt rebar3_lint 0.3.0 #101

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

I move away from OTP 18, but get back 19.1, 19.2, 20.1 and 21. 😄 In any case, if you're willing to accept this, it might solve what issues you faced. Trying to support OTP 18.3 (in testing) is incompatible with rebar3 and the newest rebar3_lint, which I also update and fix here (I didn't set off to mix both these issues, but won't want to fix them separately).

Edit: maybe closes #99 and closes #100.

paulo-ferraz-oliveira commented 3 years ago

Ideally the erlang docker images would up the git version 🤔

One day I'm sure they will, but ideally so would they use the most recent rebar3 version (or at least one that wouldn't break the CI).

paulo-ferraz-oliveira commented 3 years ago

If the latest commit's CI tests pass, I guess this is good for merge (?)

andreineculau commented 3 years ago

THANK YOU!