search

for-GET / jesse

jesse (JSon Schema Erlang) is an implementation of a JSON Schema validator for Erlang.
https://github.com/for-get/jesse
Apache License 2.0
126 stars 64 forks source link

Move CI away from -rc3 and into "the real thing" #106

Closed paulo-ferraz-oliveira closed 3 years ago

andreineculau commented 3 years ago

re: https://github.com/for-GET/jesse/pull/105#issuecomment-831594243 I remember replying to you, but heck if I know what happened to my reply. I was asking you if you have a clever idea to not need to manually update that, or at least add a check so CI fails when we forget to update.

I have a suggestion around that: since there is a erlang:latest docker image, we could maybe have latest in the list for otp_vsn and then the shell check can be simply if matrix.otp_vsn = latest then ... (pseudo). WDYT?

paulo-ferraz-oliveira commented 3 years ago

WDYT?

Might work, let me try. I wasn't looking at this "latest" part and had even forgotten about that subject 😄

Edit: 4279dac 👈 if this passes, the only question here is "Do we want to keep 24.0 next to latest - which would mean that we'd need to know what latest is, every time -, or are we Okay with a potentially duplicate CI run, currently "24.0 and latest"?

Edit 2: actually, let me try and add some if to it.

paulo-ferraz-oliveira commented 3 years ago

I'll squash everything now. @andreineculau, how'd'you like the end result?

Edit: left some comments here and there, for review clarity.

andreineculau commented 3 years ago

Thanks for the changes! 🎉