search

for-GET / jesse

jesse (JSon Schema Erlang) is an implementation of a JSON Schema validator for Erlang.
https://github.com/for-get/jesse
Apache License 2.0
124 stars 64 forks source link

Remove dependencies if not needed #138

Closed NelsonVides closed 2 months ago

NelsonVides commented 2 months ago

Just trying to minimise the amount of code and dependencies a project gets, OTP covers RFC3339 since 21.0, and json since 27.0. I'd like to slim of dependencies my deployments and OTP's libraries have better support (and performance).

Edit: just wrapped the logic around a OTP_RELEASE macro, that way we can keep backwards compatibility.

andreineculau commented 2 months ago

Fantastic Nelson! I'll have a look

PS: backwards compatibility for OSS is more of a black box but thanks to the setup we have is fairly smooth

NelsonVides commented 2 months ago

Hey there :) Any updates on this one? Just asking for a timeline, no pressure intended 🥲

zmstone commented 2 months ago

Unsure why github actions are not triggered.

andreineculau commented 2 months ago

Unsure why github actions are not triggered.

First time contributors. Need to click Checks > CI > Approve and Run.

https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/approving-workflow-runs-from-public-forks

NelsonVides commented 2 months ago

@andreineculau any updates on this one? 😇

NelsonVides commented 2 months ago

Thank you for your patience and for the reminder. CI is green 💪 I left some suggestions which are just the beard talking. I wait briefly for your reply, and then merge and schedule a version

Thank YOU!

Comments applied 💪🏽

Looking forward for a new version! 🙃

andreineculau commented 2 months ago

Published. Hope everything still works >_<