search

for-GET / jesse

jesse (JSon Schema Erlang) is an implementation of a JSON Schema validator for Erlang.
https://github.com/for-get/jesse
Apache License 2.0
124 stars 64 forks source link

Implement GitHub Actions #98

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

You might also want to reference the "build" status in README.md.

I think you need to "activate" GitHub Actions on master after which I can rebase this for testing.

Closes #97.

Note: I added the 23-branch of OTP to the mix and made latest=23.1.

paulo-ferraz-oliveira commented 3 years ago

Hi. Is this OK for merging? Do you want further changes?

paulo-ferraz-oliveira commented 3 years ago

Ping.

andreineculau commented 3 years ago

Thanks. It was a shit show. Among the highlights:

one alternative is to drop the erlang containers and use kerl.

another alternative: since github actions installs linuxbrew (homebrew), it is possible to install a specific erlang version via homebrew, but then we need to make a local copy in the repo of the respective homebrew formula e.g. brew install $(pwd)/Formula/erlang-18.3/erlang.rb (it's important to keep the file named erlang.rb!)

I see you've opened at least one other issue offering to port travis to github actions in rebar3_lint. My suggestion is we figure out what's the best course of action in jesse before moving forward.

paulo-ferraz-oliveira commented 3 years ago

Yeah, I had some issues here, also: https://github.com/inaka/elvis/pull/559/files, where Git has to be installed, since the plugin does a shallow clone.

paulo-ferraz-oliveira commented 3 years ago

one alternative is to drop the erlang containers and use kerl.

What are you trying to achieve by not using the container? Do you have any "very specific" behavior that doesn't otherwise work, as-is? I've ported Travis CI to GitHub Actions in many Erlang repo.s already, and have never had any major issues, except that one with elvis whose tests depend on .git.

paulo-ferraz-oliveira commented 3 years ago

There's also this: https://github.com/marketplace/actions/setup-erlang. I don't know if you've seen it.