breaks with rebar3_lint@0.3.0

andreineculau commented 3 years ago

1683 was green: https://travis-ci.org/github/for-GET/jesse/builds/749489608 1684 was red: https://travis-ci.org/github/for-GET/jesse/builds/750746033

@paulo-ferraz-oliveira would you be so kind to have a look? I see you're active there.

I'm locking it to 0.2.0 for now. Should probably be locked anyway.

Details

# src/jesse.erl [FAIL]
192Error: 'undef' while applying rule 'no_trailing_whitespace'.
193Error: 'undef' while applying rule 'no_tabs'.
194Error: 'undef' while applying rule 'line_length'.
195# src/jesse_cli.erl [FAIL]
196Error: 'undef' while applying rule 'no_trailing_whitespace'.
197Error: 'undef' while applying rule 'no_tabs'.
198Error: 'undef' while applying rule 'line_length'.
199# src/jesse_database.erl [FAIL]
200Error: 'undef' while applying rule 'no_trailing_whitespace'.
201Error: 'undef' while applying rule 'no_tabs'.
202Error: 'undef' while applying rule 'line_length'.
203# src/jesse_error.erl [FAIL]
204Error: 'undef' while applying rule 'no_trailing_whitespace'.
205Error: 'undef' while applying rule 'no_tabs'.
206Error: 'undef' while applying rule 'line_length'.
207# src/jesse_json_path.erl [FAIL]
208  - macro_names
209    - The macro named "Exp" on line 19 does not respect the format defined by the regular expression '"^([A-Z][A-Z_0-9]+)$"'.
210Error: 'undef' while applying rule 'no_trailing_whitespace'.
211Error: 'undef' while applying rule 'no_tabs'.
212Error: 'undef' while applying rule 'line_length'.
213# src/jesse_lib.erl [FAIL]
214Error: 'undef' while applying rule 'no_trailing_whitespace'.
215Error: 'undef' while applying rule 'no_tabs'.
216Error: 'undef' while applying rule 'line_length'.
217# src/jesse_schema_validator.erl [FAIL]
218Error: 'undef' while applying rule 'no_trailing_whitespace'.
219Error: 'undef' while applying rule 'no_tabs'.
220Error: 'undef' while applying rule 'line_length'.
221# src/jesse_state.erl [FAIL]
222Error: 'undef' while applying rule 'no_trailing_whitespace'.
223Error: 'undef' while applying rule 'no_tabs'.
224Error: 'undef' while applying rule 'line_length'.
225# src/jesse_tests_util.erl [FAIL]
226Error: 'undef' while applying rule 'no_trailing_whitespace'.
227Error: 'undef' while applying rule 'no_tabs'.
228Error: 'undef' while applying rule 'line_length'.
229# src/jesse_validator_draft3.erl [FAIL]
230Error: 'undef' while applying rule 'no_trailing_whitespace'.
231Error: 'undef' while applying rule 'no_tabs'.
232Error: 'undef' while applying rule 'line_length'.
233# src/jesse_validator_draft4.erl [FAIL]
234Error: 'undef' while applying rule 'no_trailing_whitespace'.
235Error: 'undef' while applying rule 'no_tabs'.
236Error: 'undef' while applying rule 'line_length'.
237# test/jesse_json_path_tests.erl [FAIL]
238Error: 'undef' while applying rule 'no_trailing_whitespace'.
239Error: 'undef' while applying rule 'no_tabs'.
240Error: 'undef' while applying rule 'line_length'.
241# test/jesse_schema_validator_tests.erl [FAIL]
242Error: 'undef' while applying rule 'no_trailing_whitespace'.
243Error: 'undef' while applying rule 'no_tabs'.
244Error: 'undef' while applying rule 'line_length'.
245# test/jesse_tests_draft3_SUITE.erl [FAIL]
246Error: 'undef' while applying rule 'no_trailing_whitespace'.
247Error: 'undef' while applying rule 'no_tabs'.
248Error: 'undef' while applying rule 'line_length'.
249# test/jesse_tests_draft4_SUITE.erl [FAIL]
250Error: 'undef' while applying rule 'no_trailing_whitespace'.
251Error: 'undef' while applying rule 'no_tabs'.
252Error: 'undef' while applying rule 'line_length'.
253===> Linting failed
254

andreineculau commented 3 years ago

apparently I'm doing smth wrong when I try to lock it... so not locking it

rebar3 as lint lint
9
===> Fetching rebar3_lint (from {git,"project-fifo/rebar3_lint.git",
10
                       {tag,"0.2.0"}})
11
===> Errors loading plugin {rebar3_lint,
12
                               {git,
13
                                   "project-fifo/rebar3_lint.git",
14
                                   {tag,"0.2.0"}}}. Run rebar3 with DEBUG=1 set to see errors.
15
===> Command lint not found

paulo-ferraz-oliveira commented 3 years ago

Sure.

Rules line_length, etc. that are failing with undef moved from elvis_style to elvis_text_style. elvis_core mentions it, rebar3_lint doesn't.

As for macro Exp you can either tweak the regex, disable the rule or "fix" the macro name. The reasoning is here, so it's a fix not a regression. In any case it wasn't signaled.

I can PR, but I'd need to know what to do with the macro. Here's the reference, in case you decide to go ahead: https://github.com/inaka/elvis_core/wiki/Rules#macro-names.

paulo-ferraz-oliveira commented 3 years ago

apparently I'm doing smth wrong when I try to lock it... so not locking it

A simple {rebar3_lint, "0.2.0"} should suffice.

for-GET / jesse

breaks with rebar3_lint@0.3.0 #99