for-GET / katt

KATT (Klarna API Testing Tool) is an HTTP-based API testing tool for Erlang.
https://github.com/for-GET/katt
Apache License 2.0
119 stars 16 forks source link

move from lhttpc #17

Closed andreineculau closed 8 years ago

andreineculau commented 9 years ago

to

isakb commented 8 years ago

Out of curiosity, what was the actual issue with lhttpc? Anything that didn't work well with it that required a move, or is it outdated or something? (Since a patch with 53 additions and 21 deletions seem like a step in the wrong direction from my point of view - unless the extra code adds some valuable feature that was missing.)

andreineculau commented 8 years ago

from https://github.com/esl/lhttpc "This project is not supported anymore."

Took 1.5 years to merge the simple https://github.com/esl/lhttpc/pull/43, meanwhile we were running on some fork (not a proper lhttpc-next fork, but the fork that had this commit alone)...

The numbers are deceiving though, because the committer (me) chose the least-changes path (not out of being lazy :) but because I wanted #22 to be done before touching more the tests). Similarly, at least 6 lines are just about list-binary conversions, so one could argue "if only KATT was using binaries from the start.."

isakb commented 8 years ago

Fair enough :)