search

for-GET / katt

KATT (Klarna API Testing Tool) is an HTTP-based API testing tool for Erlang.
https://github.com/for-GET/katt
Apache License 2.0
119 stars 16 forks source link

try to fix inaka gadget hooks #26

Closed andreineculau closed 8 years ago

andreineculau commented 8 years ago

@elbrujohalcon can you help out on why gadget/compiler and gadget/xref fail with this cryptic 2 code? I have removed gadget/dialyzer at least, since it's only compatible with erlang.mk. Thanks a bunch!

elbrujohalcon commented 8 years ago

I'm on vacation, but @euen is working precisely on that these days

elbrujohalcon commented 8 years ago

I just realized that @euen will be on vacation too this week. Hopefully, @harenson can take a look at the server logs... And once @euen is done you will have a page to see the errors yourself :)

andreineculau commented 8 years ago

Thank you. Now enjoy your vacation, Bruno :) This can wait

On Sun, Jan 31, 2016 at 5:35 AM, Brujo Benavides notifications@github.com wrote:

I just realized that @euen https://github.com/euen will be on vacation too this week. Hopefully, @harenson https://github.com/harenson can take a look at the server logs... And once @euen https://github.com/euen is done you will have a page to see the errors yourself :)

— Reply to this email directly or view it on GitHub https://github.com/for-GET/katt/pull/26#issuecomment-177388678.

andreineculau.com http://www.andreineculau.com

harenson commented 8 years ago

@andreineculau Hi, please come along and join us on our public HipChat channel and ping me so I can help you.

andreineculau commented 8 years ago

@elbrujohalcon take it easy on your vacation, but when you're back, please have a look at this yourself ;) thanks!

elbrujohalcon commented 8 years ago

@andreineculau let's start checking…

elbrujohalcon commented 8 years ago

@andreineculau I found the issue! The whole problem is that the folder in which gadget clones your repo is not called katt and you are using the fact that you're on a folder called katt while compiling your project in this line:

-include_lib("katt/include/blueprint_types.hrl").

Any particular reason for using include_lib instead of include there?

elbrujohalcon commented 8 years ago

BTW, @andreineculau … I changed that line to

-include("blueprint_types.hrl").

and gadget had no more issues (check inaka/katt#1).

I tried to run make test with and without the change in several tests failed in both cases (always the same tests, which is comforting)