search

for-GET / katt

KATT (Klarna API Testing Tool) is an HTTP-based API testing tool for Erlang.
https://github.com/for-GET/katt
Apache License 2.0
119 stars 16 forks source link

Using BARE_MODE #44

Closed tjarvstrand closed 8 years ago

tjarvstrand commented 8 years ago

Hi,

I realized that BARE_MODE in it's current form doesn't in fact solve our problem. Since katt is a rebar dependency of our project and hackney is a subdependency it will get pulled down during the get-deps step. There is no time to create the marker file since the rebar command is atomic as far as make is concerned.

It would be nice if there were an environment variable that could be set.

andreineculau commented 8 years ago

Right. Unfortunately I cannot do anything at the moment but accept a PR, if you want smth fast. Allowing KATT_DEV_MODE and KATT_BARE_MODE as env variables equivalent to .rebar/* file markers in the makefile (or even better in the rebar.config.script - along with checking also the CI env variables) would get :+1: from me.

tjarvstrand commented 8 years ago

I have to put it in the rebar.config.script for our build to be able to pick it up. I tried it out and it works fine except for the escriptize target. I may have to put environment variable checks in both files which is a bit ugly. WDYT?

andreineculau commented 8 years ago

Go for it

On 22 Mar 2016, at 23:34, Thomas Järvstrand notifications@github.com wrote:

I have to put it in the rebar.config.script for our build to be able to pick it up. I tried it out and it works fine except for the escriptize target. I may have to put environment variable checks in both files which is a bit ugly. WDYT?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub

andreineculau commented 8 years ago

Fixed in #45