search

forax / pro

A Java build tool that works seamlessly with modules
GNU General Public License v3.0
103 stars 15 forks source link

Fix ModuleFixerPlugin "provides" scanning #15

Closed sormuras closed 7 years ago

sormuras commented 7 years ago

Stream all resources, don't filter ".class" ones. Crop "META-INF/services/" from service name start.

sormuras commented 7 years ago

Re-fixes #14

forax commented 7 years ago

Hi Christian, if you remove "private" in front of packageOf, i will accept your PR.

If packageOf is private, because packageOf is accessed inside an anonymous class, the compiler has to create an accessor method because the VM will not allow a class (even an anonymous class) to access to a private member [1].

[1] http://stackoverflow.com/questions/2199175/java-inner-outer-class-questions-about-outer-class-private-variables-access

sormuras commented 7 years ago

Done.

forax commented 7 years ago

Thanks Christian !

sormuras commented 7 years ago

De rien.