search

forax / pro

A Java build tool that works seamlessly with modules
GNU General Public License v3.0
103 stars 15 forks source link

Let external plugins optionally resolve with core deps #36

Closed sormuras closed 5 years ago

sormuras commented 7 years ago

The three API lines should not be necessary. The three modules are already present at ./deps.

How do I configure the "resolver" to use the ./deps folder -- or would that contradict the notion of being an external plugin?

forax commented 7 years ago

it should already works because of https://github.com/forax/pro/blob/master/src/main/java/com.github.forax.pro.bootstrap/com/github/forax/pro/bootstrap/Bootstrap.java#L112 ?

forax commented 7 years ago

Ok, got it, the problem is how the resolver works, it first finds the dependencies transitively and at that point, it doesn't check that the dependencies may already exists in another directory deps.

The problem is that the jar already downloaded do not stores their Maven (central) artifact id if they are not created by Maven.

A workaround is to remove the downloaded jars in plugin/tester/deps after being downloaded

sormuras commented 5 years ago

Methinks, this issue was resolved some time ago. Correct?

forax commented 5 years ago

yes !